function for making new blog posts#171
Merged
Merged
Conversation
topepo
commented
Apr 16, 2024
topepo
commented
Apr 16, 2024
topepo
commented
Apr 16, 2024
topepo
marked this pull request as ready for review
April 16, 2024 18:34
Collaborator
Author
|
GHA failures are now down to infrastructure issues, not failing |
cderv
reviewed
May 15, 2024
cderv
left a comment
cderv
left a comment
Member
There was a problem hiding this comment.
Thanks a lot ! This will be really useful.
Do you think this will be used more interactively or not ? Just curious about your use case.
Just a few suggestions below. I see that we may need to really start using fs
Also, I am wondering if we should have more check that this function is used in the right place.
- website project where blog is supported not another type or no project
- called in the root of the project so that posts folder is created in the right place
- or no matter where called, the new post is created in the right place from the root project
Again, thanks !!
Member
I have updated main to solve this. It should be ok now. |
This reverts commit be42dbd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #22
Adds some dependencies (fs, whoami).